[Differential] [Changed Subscribers] D758: Introduce IFilterStrategy::progressInLine [1/3]

[mwolff (Milian Wolff)]

mwolff added a subscriber: mwolff.

INLINE COMMENTS
  outputview/ifilterstrategy.h:46 struct
  outputview/ifilterstrategy.h:49 float percent?
  
  also save a few chars via
  
      const QString& status = {}
  outputview/ifilterstrategy.h:80 how do you differentiate between invalid and valid progress? 0% can be valid, no?
  outputview/outputexecutejob.cpp:43 cref
  outputview/outputexecutejob.cpp:409 scoped ptr + reset?
  outputview/outputfilteringstrategies.h:50 now ots public api you must use the real export macro
  outputview/outputfilteringstrategies.h:79 please do
  outputview/outputmodel.cpp:104 cref
  outputview/outputmodel.h:81 cref

REPOSITORY
  rKDEVPLATFORM KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D758

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kfunk, apol
Cc: mwolff, apol, kdevelop-devel, arrowdodger