Review Request 126663: Fix most Clazy warnings in shell/ and sublime/ subdirectories of KDevPlatform

[Sergey Popov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126663/
-----------------------------------------------------------

Review request for KDevelop and Aleix Pol Gonzalez.


Repository: kdevplatform


Description
-------

Fix most Clazy warnings in shell/ and sublime/ subdirectories in KDevPlatform.

There are two "missing Q_OBJECT macro" warnings, which I couldn't fix:
- shell/workingsets/workingsettooltipwidget.h:55:5 - KDevelop::WorkingSetToolTipWidget::FileWidget class
- shell/settings/sessionconfigskeleton.h:32:1 - KDevelop::SessionConfigSkeleton class

Related GCI-2015 task: https://codein.withgoogle.com/tasks/5743715154919424/


Diffs
-----

  shell/completionsettings.h 05f166b 
  shell/areadisplay.cpp 7699c32 
  shell/completionsettings.cpp 89cf68b 
  shell/configdialog.cpp cd292ef 
  shell/core.cpp 640079c 
  shell/debugcontroller.cpp 520a356 
  shell/documentationcontroller.cpp c517fa7 
  shell/documentcontroller.cpp 3d83376 
  shell/editorconfigpage.cpp 34f4c1c 
  shell/environmentconfigurebutton.cpp fcb988f 
  shell/languagecontroller.cpp 9a77d42 
  shell/launchconfigurationdialog.h 8a1ebfb 
  shell/launchconfigurationdialog.cpp dccc7cd 
  shell/loadedpluginsdialog.cpp 4b343cd 
  shell/mainwindow.cpp 571bfba 
  shell/mainwindow_p.cpp ac3d471 
  shell/openprojectdialog.cpp 7922234 
  shell/openprojectpage.cpp 9d1a050 
  shell/partcontroller.cpp 332fc4a 
  shell/plugincontroller.cpp 01c1c9a 
  shell/progresswidget/progressdialog.cpp 2cda081 
  shell/progresswidget/statusbarprogresswidget.cpp 46f56e9 
  shell/project.cpp a7880c1 
  shell/projectcontroller.cpp 766c280 
  shell/projectinfopage.cpp 3641ac9 
  shell/projectsourcepage.cpp 100a5d7 
  shell/runcontroller.cpp 0487fbe 
  shell/session.cpp 0cc9a0d 
  shell/sessionchooserdialog.cpp 10c7872 
  shell/sessioncontroller.cpp 58433de 
  shell/sessiondialog.cpp 1e17290 
  shell/sessionlock.cpp 2113c1c 
  shell/settings/editstyledialog.cpp ecb2240 
  shell/settings/environmentwidget.cpp 9002685 
  shell/settings/pluginpreferences.h b2e4971 
  shell/settings/pluginpreferences.cpp cc61a54 
  shell/settings/sourceformattersettings.cpp 161e2ed 
  shell/settings/templateconfig.cpp 396ea68 
  shell/settings/templatepage.cpp 9c5d8e0 
  shell/settings/uipreferences.h e813051 
  shell/sourceformattercontroller.h c47fd5f 
  shell/sourceformattercontroller.cpp ecd6abd 
  shell/statusbar.cpp 96563f8 
  shell/tests/nonguiinterfaceplugin.cpp 0051be5 
  shell/tests/test_detectedproblem.cpp 114776f 
  shell/tests/test_documentcontroller.cpp b0e75d6 
  shell/tests/test_ktexteditorpluginintegration.cpp b2c2ba0 
  shell/tests/test_plugincontroller.cpp b847e50 
  shell/tests/test_projectcontroller.cpp cdb9ba5 
  shell/tests/test_sessioncontroller.cpp 01cb4b5 
  shell/tests/test_shellbuddy.cpp 3b87189 
  shell/tests/test_shelldocumentoperation.cpp 6718ef3 
  shell/tests/test_testcontroller.cpp 1e5e101 
  shell/textdocument.cpp 501b592 
  shell/uicontroller.h 88e3da9 
  shell/uicontroller.cpp 44f35bd 
  shell/workingsetcontroller.cpp 759816a 
  shell/workingsets/closedworkingsetswidget.cpp 6c2b4c7 
  shell/workingsets/workingset.cpp 0110d05 
  shell/workingsets/workingsettoolbutton.cpp 96c3454 
  shell/workingsets/workingsettooltipwidget.cpp 696eca5 
  sublime/area.cpp 0ba14af 
  sublime/areaindex.cpp f9d585a 
  sublime/container.cpp 9e088bc 
  sublime/examples/example1main.cpp 1dfcf6e 
  sublime/examples/example2.cpp 1602c9d 
  sublime/examples/example2main.cpp d917daf 
  sublime/idealcontroller.cpp 9ddb18b 
  sublime/idealdockwidget.cpp 7ea81e3 
  sublime/mainwindow.cpp 309db08 
  sublime/mainwindow_p.cpp 32d9038 
  sublime/tests/areaprinter.cpp 5cb6255 
  sublime/tests/test_aggregatemodel.cpp 20fc6d8 
  sublime/tests/test_areaoperation.cpp 8a9c1a8 
  sublime/tests/test_areawalker.cpp 7c31598 
  sublime/tests/test_controller.cpp 485a858 
  sublime/tests/test_document.cpp 8139fc3 
  sublime/tests/test_toolviewtoolbar.cpp 837a760 
  sublime/tests/test_view.cpp 34479d5 
  sublime/tests/test_viewactivation.cpp ac50d95 
  sublime/tooldocument.h 50014a4 

Diff: https://git.reviewboard.kde.org/r/126663/diff/


Testing
-------

Sucessfully built


Thanks,

Sergey Popov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160107/513b04ce/attachment.html>