[Differential] [Updated] D750: [GCI] Add buttons "jump to first (last) item" to standardoutputview/outputwidget.

kfunk (Kevin Funk) noreply at phabricator.kde.org
Wed Jan 6 13:53:44 UTC 2016


kfunk added a comment.

Rest LGTM, thanks!


INLINE COMMENTS
  outputview/outputmodel.cpp:313 Coding style: Opening brace on same line {.
  
  (Not for the definition itself (cf. line 310), that is okay)
  plugins/standardoutputview/outputwidget.cpp:434 Nitpick: Remove newline
  plugins/standardoutputview/outputwidget.h:84 Now it is no longer just a "Direction" -- maybe call it "SelectionMode"? (better suggestions welcome)

REPOSITORY
  rKDEVPLATFORM KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D750

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ematirov, kfunk
Cc: kdevelop-devel


More information about the KDevelop-devel mailing list