[Differential] [Commented On] D734: CMake: Fix target enumerating on Windows. For some reason, $ at the end of regexp causes matches to be empty. While there, filter out internal CMake targets.

[kfunk (Kevin Funk)]

kfunk added a comment.

Feel free to push after fixing those minor issues. Thanks!


INLINE COMMENTS
  projectmanagers/cmake/tests/test_cmakemanager.cpp:308 Cleaner to use absolute file paths here:  `QDir::tempPath() + "/TargetDirectories.txt"`
  
  -> Doesn't pollute your CWD
  projectmanagers/cmake/tests/test_cmakemanager.cpp:309 Dito, using the default ctor of `QTemporaryDir` is fine already.

REPOSITORY
  rKDEVELOP KDevelop

BRANCH
  5.0

REVISION DETAIL
  https://phabricator.kde.org/D734

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: arrowdodger, apol, kfunk
Cc: kdevelop-devel, arrowdodger