[Differential] [Commented On] D734: CMake: Fix target enumerating on Windows. For some reason, $ at the end of regexp causes matches to be empty. While there, filter out internal CMake targets.

[kfunk (Kevin Funk)]

kfunk added inline comments.

INLINE COMMENTS
  projectmanagers/cmake/tests/test_cmakemanager.cpp:304 Be explicit: Call it `testEnumerateTargets()`
  projectmanagers/cmake/tests/test_cmakemanager.cpp:308 `QTemporaryFile`?
  projectmanagers/cmake/tests/test_cmakemanager.cpp:320 Better use `QTemporaryDir("/path/to/subdir")` on the stack => takes care of construction & deletion of this dir

REPOSITORY
  rKDEVELOP KDevelop

BRANCH
  5.0

REVISION DETAIL
  https://phabricator.kde.org/D734

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: arrowdodger, apol, kfunk
Cc: kdevelop-devel, arrowdodger