[Differential] [Commented On] D734: CMake: Fix target enumerating on Windows. For some reason, $ at the end of regexp causes matches to be empty. While there, filter out internal CMake targets.

kfunk (Kevin Funk) noreply at phabricator.kde.org
Mon Jan 4 09:48:47 UTC 2016


kfunk added inline comments.

INLINE COMMENTS
  projectmanagers/cmake/cmakeimportjsonjob.cpp:114 Could also switch to `QTextStream`-based file reading, which strips \r\n and \n. Makes this code more readable and avoids us having to do implement platform-specific behavior.
  
  See: http://doc.qt.io/qt-5/qtextstream.html#readLine

REPOSITORY
  rKDEVELOP KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D734

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: arrowdodger, kfunk, apol
Cc: kdevelop-devel, arrowdodger


More information about the KDevelop-devel mailing list