[Differential] [Commented On] D734: CMake: Fix target enumerating on Windows. For some reason, $ at the end of regexp causes matches to be empty. While there, filter out internal CMake targets.

apol (Aleix Pol Gonzalez) noreply at phabricator.kde.org
Mon Jan 4 01:10:01 UTC 2016


apol added inline comments.

INLINE COMMENTS
  projectmanagers/cmake/cmakeimportjsonjob.cpp:114 Well, changing the line would mean to remove it because either we don't understand how QRegularExpression works or because ::readLine() isn't doint its job well (and thus should be properly fixed in Qt).

REPOSITORY
  rKDEVELOP KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D734

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: arrowdodger, apol, kfunk
Cc: kdevelop-devel, arrowdodger


More information about the KDevelop-devel mailing list