Review Request 127061: duchain: builder: display offsets in bytes

Alexandre Courbot gnurou at gmail.com
Mon Feb 29 09:06:30 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127061/
-----------------------------------------------------------

(Updated Feb. 29, 2016, 9:06 a.m.)


Review request for KDevelop.


Changes
-------

Sorry for the time it took to come back to this. Milian's suggestion was what looked best, so eventually I ended up taking it almost as-is. Looks much better than the first approach, thanks!


Repository: kdevelop


Description
-------

Having the offsets of members in a structure displayed is extremely
useful for people who work with data structures. However the unit
chosen (bits) is not really common. This patch changes it to bytes. If
an offset doesn't round to a byte position, the extra bits are also
displayed.


Diffs (updated)
-----

  languages/clang/duchain/builder.cpp baf4f5627d37655fb10d17355419393d77a8396a 

Diff: https://git.reviewboard.kde.org/r/127061/diff/


Testing
-------


Thanks,

Alexandre Courbot

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160229/e4303a4e/attachment.html>


More information about the KDevelop-devel mailing list