Review Request 127152: Use QProcess where KProcess is not needed

[Aleix Pol Gonzalez]

> On Feb. 23, 2016, 9:32 a.m., Laurent Navet wrote:
> > documentation/qthelp/qthelpqtdoc.cpp, line 62
> > <https://git.reviewboard.kde.org/r/127152/diff/1/?file=445074#file445074line62>
> >
> >     Sorry, can you clarify please
> >     What's the problem ?

You can change it to use initializer lists.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127152/#review92656
-----------------------------------------------------------


On Feb. 22, 2016, 9:59 p.m., Laurent Navet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127152/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2016, 9:59 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> replace KProcess by QProcess where it doesn't overbloat the code
> 
> 
> Diffs
> -----
> 
>   documentation/qthelp/qthelpqtdoc.cpp 817da64 
>   kdeintegration/executeplasmoid/plasmoidexecutionjob.h b862ff4 
>   projectbuilders/cmakebuilder/cmakebuilder.cpp 197abf1 
>   projectbuilders/ninjabuilder/ninjajob.h 22c821f 
>   projectbuilders/ninjabuilder/ninjajob.cpp e46e1ea 
>   projectmanagers/cmake/cmakebuilddirchooser.cpp febe173 
>   projectmanagers/cmake/parser/cmakeprojectvisitor.cpp 8f4df9d 
>   projectmanagers/cmake/testing/ctestfindjob.h 5ab4c7a 
>   projectmanagers/cmake/testing/ctestfindjob.cpp 7bac3cc 
>   projectmanagers/cmake/testing/ctestrunjob.h 2618a93 
>   projectmanagers/cmake/testing/ctestrunjob.cpp 4145592 
>   projectmanagers/cmake/testing/ctestsuite.cpp 66a96db 
>   projectmanagers/cmake/tests/cmakecompliance.cpp 20b6f9d 
>   projectmanagers/custom-buildsystem/custombuildjob.cpp 64d208a 
>   projectmanagers/qmake/qmakejob.h 0c2a332 
>   projectmanagers/qmake/qmakejob.cpp acc8c05 
> 
> Diff: https://git.reviewboard.kde.org/r/127152/diff/
> 
> 
> Testing
> -------
> 
> Build and run
> 
> 
> Thanks,
> 
> Laurent Navet
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160224/ce324858/attachment.html>