[Differential] [Updated] D1005: Added "move into source" helper

[kfunk (Kevin Funk)]

kfunk added a comment.


  Just had a brief look

INLINE COMMENTS
  languages/clang/clangsupport.cpp:278 FYI: The reason this shortcut was changed:
  
  commit bee81aa39f493733d411dfa7efaeb89720237ecc
  Author: Olivier JG <olivier.jg at gmail.com>
  Date:   Fri Oct 9 12:24:53 2015 +0200
  
      Fixes for rename action
      
      Don't duplicate BasicRefactoring
      Use KActionCollection::setDefaultShortcut to make it configurable
      *Use a default shortcut that doesn't conflict with Klipper
  
  Not sure what else to use, though. IMO we should put the refactoring actions into a context menu/popup we can invoke with a keyboard shortcut instead.
  
  Something for a future commit.
  languages/clang/codegen/simplerefactoring.cpp:59 Early return?
  languages/clang/codegen/simplerefactoring.cpp:62 Ditto
  languages/clang/codegen/simplerefactoring.cpp:109 Nitpick: Remove newline
  languages/clang/codegen/simplerefactoring.cpp:198 QVector?

REPOSITORY
  rKDEVELOP KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D1005

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: skalinichev
Cc: kfunk, kdevelop-devel, KDevelop, arrowdodger