[Differential] [Request, 26 lines] D1002: Do not try to cleanup the DUChain while parse jobs are running.
mwolff (Milian Wolff)
noreply at phabricator.kde.org
Sun Feb 21 22:03:29 UTC 2016
mwolff created this revision.
mwolff added reviewers: KDevelop, kfunk.
Herald added a subscriber: kdevelop-devel.
REVISION SUMMARY
This can interfer drastically with the ongoing parse jobs. Most
notably, I just encountered a case where a long-running parse job
was ongoing, but all other parse threads where waiting since the
cleanup thread already tried to lock for write, thereby starving
the parse jobs.
I think we should wait with the cleanup until the parse jobs have
finished. To do so, we try to lock for write and give up if this
does not succeed.
TEST PLAN
seems to work as intended.
REPOSITORY
rKDEVPLATFORM KDevPlatform
BRANCH
5.0
REVISION DETAIL
https://phabricator.kde.org/D1002
AFFECTED FILES
language/duchain/duchain.cpp
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mwolff, KDevelop, kfunk
Cc: kdevelop-devel
More information about the KDevelop-devel
mailing list