[Differential] [Request, 26 lines] D997: Do not try to cleanup the DUChain while parse jobs are running.

mwolff (Milian Wolff) noreply at phabricator.kde.org
Sun Feb 21 00:10:38 UTC 2016


mwolff created this revision.
mwolff added a reviewer: KDevelop.
Herald added a subscriber: kdevelop-devel.

REVISION SUMMARY
  This can interfer drastically with the ongoing parse jobs. Most
  notably, I just encountered a case where a long-running parse job
  was ongoing, but all other parse threads where waiting since the
  cleanup thread already tried to lock for write, thereby starving
  the parse jobs.
  
  I think we should wait with the cleanup until the parse jobs have
  finished. To do so, we try to lock for write and give up if this
  does not succeed.

TEST PLAN
  Seems to work as I intended. On shutdown, we still wait for the jobs
  and cleanup unconditionally. But while a big project is parsed, no
  cleanup is taking place.

REPOSITORY
  rKDEVPLATFORM KDevPlatform

BRANCH
  5.0

REVISION DETAIL
  https://phabricator.kde.org/D997

AFFECTED FILES
  language/duchain/duchain.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mwolff, KDevelop
Cc: kdevelop-devel


More information about the KDevelop-devel mailing list