[Differential] [Requested Changes To] D988: Fix parsing of the ::class constant

[mwolff (Milian Wolff)]

mwolff requested changes to this revision.
mwolff added a reviewer: mwolff.
mwolff added a comment.
This revision now requires changes to proceed.


  One performance related change, otherwise excellent work! Are you interested in doing more PHP related changes? I'd really welcome mentoring you more in that area - that plugin needs someone who looks after it! If you have any questions, don't hesitate to ask us on our mailing list.
  
  Cheers, and thanks again!

INLINE COMMENTS
  duchain/expressionvisitor.cpp:419 make it:
  
      if (!stringForNode(node->classConstant).compare(QLatin1String("class"), Qt::CaseInsensitive))
  
  this is much faster as it removes two runtime memory allocations.

REPOSITORY
  rKDEVPHP KDev-php

REVISION DETAIL
  https://phabricator.kde.org/D988

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: visscher, KDevelop, mwolff
Cc: kdevelop-devel, mwolff