Review Request 127113: WIP: Attempt at dropping Plasma Components usage

[Aleix Pol Gonzalez]

> On Feb. 19, 2016, 1:40 p.m., Kevin Funk wrote:
> > plugins/welcomepage/qml/Develop.qml, line 66
> > <https://git.reviewboard.kde.org/r/127113/diff/1/?file=444666#file444666line66>
> >
> >     I'm surprised you need a ScrollView here? ListView already is a flickable item?

It's to actually get the scroll bar.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127113/#review92556
-----------------------------------------------------------


On Feb. 19, 2016, 1:16 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127113/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2016, 1:16 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> I started working on it, left it half-way.
> 
> I saw people are looking into this, decided to publish in case somebody wants to push it. Otherwise I will at some point.
> 
> 
> Diffs
> -----
> 
>   plugins/welcomepage/qml/Develop.qml 29e167d 
>   plugins/welcomepage/qml/GettingStarted.qml 71525a8 
>   plugins/welcomepage/qml/Heading.qml 182781f 
>   plugins/welcomepage/qml/Link.qml 844e223 
>   plugins/welcomepage/qml/area_code.qml 30a901b 
>   plugins/welcomepage/qml/area_debug.qml 65b1e47 
>   plugins/welcomepage/qml/area_review.qml a6fc540 
>   plugins/welcomepage/qml/plugins/Branches.qml 2222604 
>   plugins/welcomepage/qml/plugins/Projects.qml ba91645 
> 
> Diff: https://git.reviewboard.kde.org/r/127113/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160219/8e834af1/attachment-0001.html>