[Differential] [Request, 6 lines] D939: Fix TestModels::testVcsFileChangesModel regression.
mwolff (Milian Wolff)
noreply at phabricator.kde.org
Sun Feb 14 16:51:09 UTC 2016
mwolff created this revision.
mwolff added a reviewer: KDevelop.
Herald added a subscriber: kdevelop-devel.
REVISION SUMMARY
When queried for the custom data roles, always delegate to the
custom VcsStatusInfoItem. This fixes an issue uncovered by the test,
where the QStandardItem holding the icon and path is returned
instead of the VcsStatusInfoItem. This item has no knowledge of the
custom data roles, and thus always returns invalid QVariants then.
TEST PLAN
Works now
REPOSITORY
rKDEVPLATFORM KDevPlatform
BRANCH
5.0
REVISION DETAIL
https://phabricator.kde.org/D939
AFFECTED FILES
vcs/models/tests/test_models.cpp
vcs/models/vcsfilechangesmodel.cpp
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mwolff, KDevelop
Cc: kdevelop-devel
More information about the KDevelop-devel
mailing list