Review Request 127050: [kdevplatform] Show job progress in Task Manager

Kai Uwe Broulik kde at privat.broulik.de
Sat Feb 13 16:46:55 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127050/
-----------------------------------------------------------

(Updated Feb. 13, 2016, 4:46 nachm.)


Review request for KDevelop and Kevin Funk.


Changes
-------

* Address Milian's comments
* Fix potential division by zero


Repository: kdevplatform


Description
-------

Using the Unity Launcher API. Not super optimal of using this unstable private DBus thingie but whatever. Maybe some day we'll have KF5 Window Metadata :)

QtCreator also shows a badge with the number of build problems which is kinda neat but this is probably in KDevelop somewhere and not the platform?


Diffs (updated)
-----

  shell/CMakeLists.txt 83d4db0 
  shell/runcontroller.h a6684f9 
  shell/runcontroller.cpp 9f5259a 
  shell/unitylauncher.h PRE-CREATION 
  shell/unitylauncher.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/127050/diff/


Testing
-------

Video: https://www.youtube.com/watch?v=9pwhurPo--M

While at it I replaced keys() creating a temporary QList just to iterate over it with iterators and using .key() - unfortunately we cannot use keyBegin() yet

I could move all of this into the RunControllerPrivate (my initial much more complex attempt registered a dbus service so I used a separate class)


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160213/237697b0/attachment.html>


More information about the KDevelop-devel mailing list