Review Request 127050: [kdevplatform] Show job progress in Task Manager
Kai Uwe Broulik
kde at privat.broulik.de
Fri Feb 12 10:41:35 UTC 2016
> On Feb. 12, 2016, 12:13 vorm., Milian Wolff wrote:
> > looks nice! so this is not only used by unity but also by kde now? is the unity name required or can we find a more generic name?
>
> Aleix Pol Gonzalez wrote:
> AFAIK it's a Unity interface that Plasma is sniffing for such feedback. The name probably should stay.
>
> Kai Uwe Broulik wrote:
> I'm quite indifferent on the naming, if you suggest a better name, I'd be happy to use it :)
perhaps "TaskManagerProgress"? We could also incorporate Qt Windows Extras in there: https://doc.qt.io/qt-5/qtwinextras-overview.html#overlay-icons-and-progress-indicators
- Kai Uwe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127050/#review92282
-----------------------------------------------------------
On Feb. 11, 2016, 9:47 nachm., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127050/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2016, 9:47 nachm.)
>
>
> Review request for KDevelop and Kevin Funk.
>
>
> Repository: kdevplatform
>
>
> Description
> -------
>
> Using the Unity Launcher API. Not super optimal of using this unstable private DBus thingie but whatever. Maybe some day we'll have KF5 Window Metadata :)
>
> QtCreator also shows a badge with the number of build problems which is kinda neat but this is probably in KDevelop somewhere and not the platform?
>
>
> Diffs
> -----
>
> shell/CMakeLists.txt 83d4db0
> shell/runcontroller.h a6684f9
> shell/runcontroller.cpp 9f5259a
> shell/unitylauncher.h PRE-CREATION
> shell/unitylauncher.cpp PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/127050/diff/
>
>
> Testing
> -------
>
> Video: https://www.youtube.com/watch?v=9pwhurPo--M
>
> While at it I replaced keys() creating a temporary QList just to iterate over it with iterators and using .key() - unfortunately we cannot use keyBegin() yet
>
> I could move all of this into the RunControllerPrivate (my initial much more complex attempt registered a dbus service so I used a separate class)
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160212/76e83d7e/attachment.html>
More information about the KDevelop-devel
mailing list