Review Request 127050: [kdevplatform] Show job progress in Task Manager

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127050/#review92282
-----------------------------------------------------------


Fix it, then Ship it!




looks nice! so this is not only used by unity but also by kde now? is the unity name required or can we find a more generic name?


shell/runcontroller.cpp (line 612)
<https://git.reviewboard.kde.org/r/127050/#comment62946>

    please use the newstyle connect syntax



shell/runcontroller.cpp (line 644)
<https://git.reviewboard.kde.org/r/127050/#comment62947>

    a real? really? ;-) the jobcount is integral, no?



shell/runcontroller.cpp (line 659)
<https://git.reviewboard.kde.org/r/127050/#comment62948>

    static cast to float here if you want, or don't and just do
    
        ...->setProgress((totalProgress + 1) / jobCount);
    
    the result should be the same as a floating point devision + qRound afaik.



shell/runcontroller.cpp (line 735)
<https://git.reviewboard.kde.org/r/127050/#comment62949>

    just remove the unused arguments



shell/unitylauncher.h (line 36)
<https://git.reviewboard.kde.org/r/127050/#comment62950>

    remove virtual, add override



shell/unitylauncher.h (line 45)
<https://git.reviewboard.kde.org/r/127050/#comment62951>

    class is not exported, don't pimpl it



shell/unitylauncher.cpp (line 35)
<https://git.reviewboard.kde.org/r/127050/#comment62952>

    remove


- Milian Wolff


On Feb. 11, 2016, 9:47 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127050/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2016, 9:47 p.m.)
> 
> 
> Review request for KDevelop and Kevin Funk.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Using the Unity Launcher API. Not super optimal of using this unstable private DBus thingie but whatever. Maybe some day we'll have KF5 Window Metadata :)
> 
> QtCreator also shows a badge with the number of build problems which is kinda neat but this is probably in KDevelop somewhere and not the platform?
> 
> 
> Diffs
> -----
> 
>   shell/CMakeLists.txt 83d4db0 
>   shell/runcontroller.h a6684f9 
>   shell/runcontroller.cpp 9f5259a 
>   shell/unitylauncher.h PRE-CREATION 
>   shell/unitylauncher.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127050/diff/
> 
> 
> Testing
> -------
> 
> Video: https://www.youtube.com/watch?v=9pwhurPo--M
> 
> While at it I replaced keys() creating a temporary QList just to iterate over it with iterators and using .key() - unfortunately we cannot use keyBegin() yet
> 
> I could move all of this into the RunControllerPrivate (my initial much more complex attempt registered a dbus service so I used a separate class)
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160212/650fdd07/attachment-0001.html>