Review Request 127043: Fix -Wcast-align warning by using new Python API

[Sven Brauch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127043/#review92268
-----------------------------------------------------------


Fix it, then Ship it!




Assuming you ran the unit tests, and the unicode strings in there didn't crash it, go for it :)


parser/astbuilder.cpp (line 368)
<https://git.reviewboard.kde.org/r/127043/#comment62938>

    str is good, at least it always worked before



parser/astbuilder.cpp (line 369)
<https://git.reviewboard.kde.org/r/127043/#comment62937>

    Actually ... yes, I think so. Reading the source, it calls Py_INCREF.


- Sven Brauch


On Feb. 11, 2016, 5:12 p.m., Alex Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127043/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2016, 5:12 p.m.)
> 
> 
> Review request for KDevelop and Sven Brauch.
> 
> 
> Repository: kdev-python
> 
> 
> Description
> -------
> 
> This should also be slightly more performant as Python doesn't have to
> convert to a different unicode format first.
> 
> 
> Diffs
> -----
> 
>   parser/astbuilder.cpp aec888ab2e25341d7d0b65a9b7a1010b0e97ebba 
> 
> Diff: https://git.reviewboard.kde.org/r/127043/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160211/974d3ebb/attachment.html>