Review Request 127039: Don't add HintedType instances to UnsureType if the target type exists

[Alex Richardson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127039/
-----------------------------------------------------------

(Updated Feb. 11, 2016, 4:40 p.m.)


Review request for KDevelop.


Changes
-------

New approach retaining one hinted type per TopDUContext


Repository: kdev-python


Description
-------

Otherwise we still get UnsureTypes which have lots of entries like this:

found potential duplicates when adding N6Python10HintedTypeE int(index = 774764) ->
    67278 - int of type N8KDevelop13StructureTypeE
    102814 (aka 67278: int of type N8KDevelop13StructureTypeE) - int of type N6Python10HintedTypeE
    139700 (aka 67278: int of type N8KDevelop13StructureTypeE) - int of type N6Python10HintedTypeE
    140778 (aka 67278: int of type N8KDevelop13StructureTypeE) - int of type N6Python10HintedTypeE
    191576 (aka 67278: int of type N8KDevelop13StructureTypeE) - int of type N6Python10HintedTypeE
    206348 (aka 67278: int of type N8KDevelop13StructureTypeE) - int of type N6Python10HintedTypeE
    346692 (aka 67278: int of type N8KDevelop13StructureTypeE) - int of type N6Python10HintedTypeE
    351636 (aka 67278: int of type N8KDevelop13StructureTypeE) - int of type N6Python10HintedTypeE
    362174 (aka 351724: int of type N6Python10UnsureTypeE) - int of type N6Python10HintedTypeE
    386886 (aka 67278: int of type N8KDevelop13StructureTypeE) - int of type N6Python10HintedTypeE
    408898 (aka 67278: int of type N8KDevelop13StructureTypeE) - int of type N6Python10HintedTypeE
    533652 (aka 67278: int of type N8KDevelop13StructureTypeE) - int of type N6Python10HintedTypeE
    540306 (aka 67278: int of type N8KDevelop13StructureTypeE) - int of type N6Python10HintedTypeE
    573586 (aka 67278: int of type N8KDevelop13StructureTypeE) - int of type N6Python10HintedTypeE
    614644 (aka 67278: int of type N8KDevelop13StructureTypeE) - int of type N6Python10HintedTypeE
    618548 (aka 66042: bool of type N8KDevelop12IntegralTypeE) - bool of type N6Python10HintedTypeE
    648374 (aka 67278: int of type N8KDevelop13StructureTypeE) - int of type N6Python10HintedTypeE
    665250 (aka 67278: int of type N8KDevelop13StructureTypeE) - int of type N6Python10HintedTypeE
    709684 (aka 67278: int of type N8KDevelop13StructureTypeE) - int of type N6Python10HintedTypeE
    750432 (aka 67278: int of type N8KDevelop13StructureTypeE) - int of type N6Python10HintedTypeE
    89504 (aka 66548: str of type N8KDevelop13StructureTypeE) - str of type N6Python10HintedTypeE
    765024 (aka 90024: str of type N6Python10UnsureTypeE) - str of type N6Python10HintedTypeE
    774764 (aka 403436: int of type N6Python10UnsureTypeE) - int of type N6Python10HintedTypeE


Diffs (updated)
-----

  duchain/types/hintedtype.h a5d3816ba902069b14ff8e2c5ad5aa0571528a76 
  duchain/types/hintedtype.cpp d5d137bdc6e26a1d09ca31873ff5707029c99211 
  duchain/types/unsuretype.cpp 072aabee682a62b380e26ac04b4d42c3ba285560 

Diff: https://git.reviewboard.kde.org/r/127039/diff/


Testing
-------


Thanks,

Alex Richardson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160211/22087689/attachment-0001.html>