Review Request 127040: Look for -xc++ to determine if a parser session is CPP

[Kevin Funk]

> On Feb. 11, 2016, 3:12 p.m., Milian Wolff wrote:
> > right, but this change is still correct, is it not? Or are there cases where we only pass `--std=c++11` but not `-xc++`? Also note how this patch would also fix the function when someone uses `--std=gnu14` or similar.

Well, I don't know for sure. But looks sane => +1.

@Pedro: Curious, are you working on proper C-support for kdev-clang? Feel free to join #kdevelop @ Freenode so we can talk.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127040/#review92257
-----------------------------------------------------------


On Feb. 11, 2016, 11:45 a.m., Pedro Ferreira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127040/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2016, 11:45 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Instead of looking for -std=c++ (which according to "man gcc" isn't valid) look for "-xc++"
> I found this while working somewhere else.
> 
> 
> Diffs
> -----
> 
>   languages/clang/clangsettings/clangsettingsmanager.cpp acb7a5c 
> 
> Diff: https://git.reviewboard.kde.org/r/127040/diff/
> 
> 
> Testing
> -------
> 
> No new failures.
> Nothing fixed either.
> 
> 
> Thanks,
> 
> Pedro Ferreira
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160211/e7a2feb0/attachment.html>