[Differential] [Commented On] D932: Cannot find the 'MERGE' option into KDevPlatform VCS support source code

kfunk (Kevin Funk) noreply at phabricator.kde.org
Thu Feb 11 09:40:42 UTC 2016


kfunk added a comment.


  Could you also extend unit tests? See test_git.cpp, `GitInitTest::testBranch` function

INLINE COMMENTS
  plugins/git/gitplugin.cpp:701 Nitpick: Unrelated change
  vcs/dvcs/ui/branchmanager.cpp:181 Style: Early-return here, too
  
  ```
  if (cond) {
    // ...
    return;
  }
  ```

REPOSITORY
  rKDEVPLATFORM KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D932

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: coliveira, apol, mwolff
Cc: kfunk, kdevelop-devel, arrowdodger


More information about the KDevelop-devel mailing list