[Differential] [Requested Changes To] D583: Fix DUChainUtils::getInheriters.

David Nolden david.nolden.kdevelop at art-master.de
Wed Feb 3 13:14:14 UTC 2016

Hi, since I don't have a phabricator login, I'm commenting by e-mail.

This patch is not necessary, because a context doesn't need to import
its parent context. That happens implicity by the scoping rules.

Also, this might break the old cpp plugin as well as kdev-python and
any other plugin that might use the duchain for more than just
visualization. I find it wrong to do significant duchain code changes
and just testing them on clang, which doesn't really use the duchain.

Greetings, David

2016-02-02 23:50 GMT+01:00 kfunk (Kevin Funk) <noreply at phabricator.kde.org>:
> kfunk requested changes to this revision.
> kfunk added a reviewer: kfunk.
> kfunk added a comment.
> This revision now requires changes to proceed.
>   Okay, thanks for your feedback. Will mark this as WIP for now.
>   rKDEVPLATFORM KDevPlatform
>   https://phabricator.kde.org/D583
>   https://phabricator.kde.org/settings/panel/emailpreferences/
> To: gsmolarczyk, KDevelop, kfunk
> Cc: kfunk, olivierjg, mwolff, kdevelop-devel, arrowdodger
> _______________________________________________
> KDevelop-devel mailing list
> KDevelop-devel at kde.org
> https://mail.kde.org/mailman/listinfo/kdevelop-devel

More information about the KDevelop-devel mailing list