[Differential] [Requested Changes To] D3880: Less Code Make Tomaz Happy
brauch (Sven Brauch)
noreply at phabricator.kde.org
Fri Dec 30 19:49:43 UTC 2016
brauch requested changes to this revision.
brauch added a reviewer: brauch.
brauch added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kdevelopsessionsengine.cpp:40
> {
> + delete m_dirWatch;
> }
KDirWatch looks like a QObject, do you really need to delete it?
> kdevelopsessionsengine.cpp:45
> {
> + if(m_dirWatch)
> + delete m_dirWatch;
Does this ever happen?
> test_qthelpplugin.cpp:44
>
> -TestQtHelpPlugin::TestQtHelpPlugin()
> +TestQtHelpPlugin::TestQtHelpPlugin() :
> + m_testCore(nullptr),
use the
foo()
: m_foo(...)
, m_bar(...)
formatting please
> qmakejob.cpp:41
> QMakeJob::QMakeJob(QObject* parent)
> - : OutputExecuteJob(parent)
> - , m_killed(false)
> + : OutputExecuteJob(parent),
> + m_killed(false),
as above
REPOSITORY
R32 KDevelop
REVISION DETAIL
https://phabricator.kde.org/D3880
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: patrickelectric, #kdevelop, brauch
Cc: brauch, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161230/6abe4452/attachment.html>
More information about the KDevelop-devel
mailing list