[Differential] [Request, 35 lines] D3867: PEP-448 unpacking in dict literals.

flherne (Francis Herne) noreply at phabricator.kde.org
Thu Dec 29 20:22:49 UTC 2016


flherne created this revision.
flherne added a reviewer: brauch.
flherne set the repository for this revision to R53 KDevelop: Python Support.
Restricted Application added a subscriber: kdevelop-devel.

REVISION SUMMARY
  Logical equivalent of https://phabricator.kde.org/D3844.
  
    foo = {'a': 2}
    bar = {**foo}
  
  Previously, `foo` would incorrectly be added to the value type of `bar`.
  
  N.B. this allows Ast::DictAst::keys to contain null values (for unpacked dicts, where there is no key). This is necessary to determine which values should be unpacked, because the value node has no different properties.

TEST PLAN
  No test regressions. Two new tests previously failed, now pass.

REPOSITORY
  R53 KDevelop: Python Support

REVISION DETAIL
  https://phabricator.kde.org/D3867

AFFECTED FILES
  duchain/expressionvisitor.cpp
  duchain/tests/pyduchaintest.cpp
  parser/ast.h
  parser/conversionGenerator.py
  parser/generated.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: flherne, brauch
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161229/2f9996ba/attachment-0001.html>


More information about the KDevelop-devel mailing list