[Differential] [Accepted] D3785: Add an app_template for a simple KDevelop plugin
kfunk (Kevin Funk)
noreply at phabricator.kde.org
Thu Dec 22 00:58:19 UTC 2016
kfunk accepted this revision.
kfunk added a reviewer: kfunk.
kfunk added a comment.
This revision is now accepted and ready to land.
Rest LGTM, great!
INLINE COMMENTS
> README:1
> +Simple KDevelop Plugin
> +----------------------
Turn into a README.md (Markdown syntax) maybe? Way more common these days.
> README:23
> +
> +If you are unsure, check in the installation log the path to which the plugin is installed.
> +
"... check the output of `make install` to see where the plugin is installed" maybe?
> %{APPNAMELC}.cpp:6
> +#include <KPluginFactory>
> +K_PLUGIN_FACTORY_WITH_JSON(%{APPNAME}Factory, "%{APPNAMELC}.json", registerPlugin<%{APPNAME}>(); )
> +
Style: Add newline before, remove after
REPOSITORY
R32 KDevelop
BRANCH
addKDevPluginTemplate
REVISION DETAIL
https://phabricator.kde.org/D3785
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: kossebau, #kdevelop, kfunk
Cc: kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161222/bb74951f/attachment.html>
More information about the KDevelop-devel
mailing list