Review Request 129416: CMake ProjectManager: add advanced configuration settings
René J.V. Bertin
rjvbertin at gmail.com
Mon Dec 19 19:30:48 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129416/
-----------------------------------------------------------
(Updated Dec. 19, 2016, 7:30 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDevelop.
Changes
-------
Submitted with commit d56117d68f29fff86103758078d6cc0f7bae6dab by René J.V. Bertin to branch master.
Repository: kdevelop
Description
-------
This patch introduces something I've been missing since I started using KDevelop: the possibility to reconfigure the way CMake is called after creating a project (= through the IDE rather than by editing a file in the .kdev4 directory).
The patch introduces the equivalent of all fields available on the fields available on the cmake initial creation dialog, under the advanced button.
It's open for discussion whether the ExtraArguments field should have a history too (otherwise it could be a simple text entry box), and whether that history should be shared with the one from `CMakeBuildDirChooser`.
I'd also like to point out that with this extended interface we could provide a reset button which removes `CMakeCache.txt` and the `CMakeFiles` directory (or, more surgically, `CMakeFiles/3.*`); this is actually required for changes to certain changes like the compiler to be used.
Diffs
-----
projectmanagers/cmake/CMakeLists.txt 5097f35
projectmanagers/cmake/cmakebuilddirchooser.h 186cc24
projectmanagers/cmake/cmakebuilddirchooser.cpp 2376bd3
projectmanagers/cmake/cmakeextraargumentshistory.h PRE-CREATION
projectmanagers/cmake/cmakeextraargumentshistory.cpp PRE-CREATION
projectmanagers/cmake/settings/cmakebuildsettings.ui 96362dd
projectmanagers/cmake/settings/cmakepreferences.h d653927
projectmanagers/cmake/settings/cmakepreferences.cpp e7cfbbb
Diff: https://git.reviewboard.kde.org/r/129416/diff/
Testing
-------
Works as expected on OS X with Qt 5.6.2 and KF5 5.27.0
File Attachments
----------------
screenshot (Linux)
https://git.reviewboard.kde.org/media/uploaded/files/2016/12/13/3118dfc1-d440-4e26-80a3-edec0d4080c6__cmake-conf.png
Thanks,
René J.V. Bertin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161219/e1607bb9/attachment.html>
More information about the KDevelop-devel
mailing list