[Differential] [Accepted] D3683: StandardDocumentationView positioning fixes

[kfunk (Kevin Funk)]

kfunk accepted this revision.
kfunk added a comment.
This revision is now accepted and ready to land.


  Rest LGTM.
  
  Comments about my remark around the event filter?

INLINE COMMENTS

> standarddocumentationview.cpp:84
> +
> +    if (event->type() == QEvent::Resize) {
> +        adjustPosition();

I'm not sure we want to adjust the position on resize. I would just drop that whole event filter.

Steps to reproduce where this feature looks odd:

- Scroll to random position in the documentation view
- Resize the tool view

Actual:

- View gets scrolled back to the last looked up item

Expected:

- Shouldn't scroll

REPOSITORY
  R33 KDevPlatform

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3683

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: antonanikin, kfunk, #kdevelop
Cc: kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161217/228fa08c/attachment.html>