[Differential] [Updated] D3683: StandardDocumentationView positioning fixes

antonanikin (Anton Anikin) noreply at phabricator.kde.org
Sat Dec 17 07:02:13 UTC 2016


antonanikin marked 3 inline comments as done.
antonanikin added inline comments.

INLINE COMMENTS

> kfunk wrote in standarddocumentationview.cpp:53
> No longer needed afaics, has been introduced with https://phabricator.kde.org/R32:a108066e644861b2756009b57c02d4b42792fead.

Fixed, now we don't use JS for page scrolling.

> kfunk wrote in standarddocumentationview.cpp:106
> http://doc.qt.io/archives/qt-5.5/qwebframe.html#scrollToAnchor instead? Does that work?

Damn! How could I not notice this method??!

Thanks a lot!

REPOSITORY
  R33 KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D3683

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: antonanikin, #kdevelop, kfunk
Cc: kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161217/7e9d7939/attachment-0001.html>


More information about the KDevelop-devel mailing list