[Differential] [Requested Changes To] D3683: StandardDocumentationView positioning fixes

[kfunk (Kevin Funk)]

kfunk requested changes to this revision.
kfunk added a reviewer: kfunk.
kfunk added a comment.
This revision now requires changes to proceed.


  This leads to rendering artifacts here (Qt 5.6). When I try to open the documentation of a symbol, I get nothing displayed (see screenshot).
  
  F783965: D3683-renderingartifacts.png <https://phabricator.kde.org/F783965>

INLINE COMMENTS

> standarddocumentationview.cpp:27
>  #include <QFontDatabase>
> +#include <QTimer>
> +#include <QWebFrame>

Unused include

> standarddocumentationview.cpp:53
> +    m_view->installEventFilter(this);
> +    m_view->settings()->setAttribute(QWebSettings::JavascriptEnabled, true);
> +

No longer needed afaics, has been introduced with https://phabricator.kde.org/R32:a108066e644861b2756009b57c02d4b42792fead.

> standarddocumentationview.cpp:106
> +    else {
> +        frame->evaluateJavaScript(QStringLiteral("window.location.href = '#%1';").arg(fragment));
> +    }

http://doc.qt.io/archives/qt-5.5/qwebframe.html#scrollToAnchor instead? Does that work?

REPOSITORY
  R33 KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D3683

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: antonanikin, #kdevelop, kfunk
Cc: kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161217/9c2d3735/attachment-0001.html>