Review Request 129649: Add browser selection dialog

[Kevin Funk]

> On Dec. 14, 2016, 9:11 a.m., Kevin Funk wrote:
> > browserappconfig.cpp, line 98
> > <https://git.reviewboard.kde.org/r/129649/diff/1/?file=487395#file487395line98>
> >
> >     This will leak the dialog.
> >     
> >     Do:
> >     `diag->setAttribute(Qt::WA_DeleteOnClose);`
> 
> Alexander Zhigalin wrote:
>     Why hiding a checkbox will leak the dialog?

Wrong line. The memory allocated by the `new FooDialog` will be leaked :)


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129649/#review101428
-----------------------------------------------------------


On Dec. 13, 2016, 5:04 p.m., Alexander Zhigalin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129649/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2016, 5:04 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-executebrowser
> 
> 
> Description
> -------
> 
> Add browser selection dialog
> 
> 
> Diffs
> -----
> 
>   browserappconfig.h 9862d3424e22b41e8076e34558ecef6ab2868b45 
>   browserappconfig.cpp d11fff929fef9e5c0efb914435d615c979087eeb 
>   browserappconfig.ui a8d940e78c2794609c483cbd9c02be8d1b947bf2 
> 
> Diff: https://git.reviewboard.kde.org/r/129649/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Zhigalin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161214/bab8a366/attachment-0001.html>