Review Request 129416: CMake ProjectManager: add advanced configuration settings

[Aleix Pol Gonzalez]

> On Dec. 13, 2016, 4:25 p.m., Aleix Pol Gonzalez wrote:
> > projectmanagers/cmake/cmakeextraargumentshistory.h, line 39
> > <https://git.reviewboard.kde.org/r/129416/diff/2/?file=485669#file485669line39>
> >
> >     This is leaking already, let this class extend `KComboBox`?
> >     Or better, use QComboBox and make this class be a completion model.
> 
> René J.V. Bertin wrote:
>     I've tried to follow local practice as much as I could. I think I tried to inherit KComboBox but that didn't work for some reason, I forget what the issue was.
>     
>     What's leaking - did I forget to release something in the dtor?
>     
>     I fear I have no idea what you mean with making the class a completion model.

Just a QAbstractModelItem that you set to the QComboBox with the possibilities.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129416/#review101415
-----------------------------------------------------------


On Dec. 13, 2016, 7:33 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129416/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2016, 7:33 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> This patch introduces something I've been missing since I started using KDevelop: the possibility to reconfigure the way CMake is called after creating a project (= through the IDE rather than by editing a file in the .kdev4 directory).
> 
> The patch introduces the equivalent of all fields available on the fields available on the cmake initial creation dialog, under the advanced button.
> 
> It's open for discussion whether the ExtraArguments field should have a history too (otherwise it could be a simple text entry box), and whether that history should be shared with the one from `CMakeBuildDirChooser`.
> 
> I'd also like to point out that with this extended interface we could provide a reset button which removes `CMakeCache.txt` and the `CMakeFiles` directory (or, more surgically, `CMakeFiles/3.*`); this is actually required for changes to certain changes like the compiler to be used.
> 
> 
> Diffs
> -----
> 
>   projectmanagers/cmake/CMakeLists.txt 5097f35 
>   projectmanagers/cmake/cmakebuilddirchooser.h 186cc24 
>   projectmanagers/cmake/cmakebuilddirchooser.cpp 2376bd3 
>   projectmanagers/cmake/cmakeextraargumentshistory.h PRE-CREATION 
>   projectmanagers/cmake/cmakeextraargumentshistory.cpp PRE-CREATION 
>   projectmanagers/cmake/settings/cmakebuildsettings.ui 96362dd 
>   projectmanagers/cmake/settings/cmakepreferences.h d653927 
>   projectmanagers/cmake/settings/cmakepreferences.cpp e7cfbbb 
> 
> Diff: https://git.reviewboard.kde.org/r/129416/diff/
> 
> 
> Testing
> -------
> 
> Works as expected on OS X with Qt 5.6.2 and KF5 5.27.0
> 
> 
> File Attachments
> ----------------
> 
> screenshot (Linux)
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/12/13/3118dfc1-d440-4e26-80a3-edec0d4080c6__cmake-conf.png
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161214/b0acadd2/attachment.html>