Review Request 129649: Add browser selection dialog

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129649/#review101428
-----------------------------------------------------------




browserappconfig.cpp (line 71)
<https://git.reviewboard.kde.org/r/129649/#comment67911>

    Style: Please fix indentation



browserappconfig.cpp (line 97)
<https://git.reviewboard.kde.org/r/129649/#comment67910>

    Style: Please fix indentation



browserappconfig.cpp (line 98)
<https://git.reviewboard.kde.org/r/129649/#comment67912>

    This will leak the dialog.
    
    Do:
    `diag->setAttribute(Qt::WA_DeleteOnClose);`



browserappconfig.cpp (line 101)
<https://git.reviewboard.kde.org/r/129649/#comment67913>

    I'd check the return code of QDialog::exec(), don't call `setText` in case the user aborted the dialog.


- Kevin Funk


On Dec. 13, 2016, 5:04 p.m., Alexander Zhigalin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129649/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2016, 5:04 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-executebrowser
> 
> 
> Description
> -------
> 
> Add browser selection dialog
> 
> 
> Diffs
> -----
> 
>   browserappconfig.h 9862d3424e22b41e8076e34558ecef6ab2868b45 
>   browserappconfig.cpp d11fff929fef9e5c0efb914435d615c979087eeb 
>   browserappconfig.ui a8d940e78c2794609c483cbd9c02be8d1b947bf2 
> 
> Diff: https://git.reviewboard.kde.org/r/129649/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Zhigalin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161214/1c131819/attachment-0001.html>