Review Request 122758: [OS X] work around missing Q_COMPILER_INITIALIZER_LISTS

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122758/#review101416
-----------------------------------------------------------



Still confused about this patch... 

> OS X lacks (full) support for compiler initialiser lists, i.e. Q_COMPILER_INITIALIZER_LISTS is not defined

Where's the upstream bug report for this? Hasn't this been fixed? Did you actually retest this patch -- is it still needed?


pythonlanguagesupport.cpp (line 198)
<https://git.reviewboard.kde.org/r/122758/#comment67905>

    Why on the heap?



pythonlanguagesupport.cpp (line 226)
<https://git.reviewboard.kde.org/r/122758/#comment67904>

    Why on the heap?


- Kevin Funk


On Dec. 13, 2016, 2:44 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122758/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2016, 2:44 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and KDevelop.
> 
> 
> Repository: kdev-python
> 
> 
> Description
> -------
> 
> OS X lacks (full) support for compiler initialiser lists, i.e. Q_COMPILER_INITIALIZER_LISTS is not defined. As a result, several expressions used in kdev-python C++ code fail to compile.
> 
> This patch presents a workaround. I have used dynamically allocated class instances where an initialiser list is returned from a function, to avoid returning references to out-of-scope objects.
> 
> Please correct me if there are better ways, or if that means the objects have to deleted explicitly by the caller in order to prevent memory leaks.
> 
> 
> Diffs
> -----
> 
>   duchain/contextbuilder.cpp 79db2fad 
>   duchain/tests/pyduchaintest.cpp 05da74f5 
>   pythonlanguagesupport.cpp d8a720f6 
> 
> Diff: https://git.reviewboard.kde.org/r/122758/diff/
> 
> 
> Testing
> -------
> 
> On OS X/MacPorts with KDE libs 4.14.5 and KDevelop 4.7.1 .
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161213/0f55659a/attachment.html>