[Differential] [Commented On] D3597: Investigate warnings and fix them [3]

[ematirov (Mikhail Ivchenko)]

ematirov added inline comments.

INLINE COMMENTS

> mainwindow_p.cpp:321
>  
> +    action = KStandardAction::fullScreen( this, SLOT(toggleFullScreen(bool)), m_mainWindow, actionCollection() );
> +

1. There is no need in moving this line
2. "action = " part can be omitted since it's not used anyway.

But maybe it's better to keep it as it is since it doesn't hurt and do not create not very needed change in history. @kfunk?

> test_path.cpp:373
>  
> -    QVERIFY(left == left);
> -    QVERIFY(right == right);

Probably, this warning was false-positive warning since this one tests if equality overload is really working at all

> vcspluginhelper.cpp:427
> +
> +    QAction* copyAction = menu->addAction(QIcon::fromTheme(QStringLiteral("edit-copy")), i18n("Copy Revision"));
> +    connect(copyAction, &QAction::triggered, this, [this, rev]() {

Not really necessary probably. @kfunk, same question?

REPOSITORY
  R33 KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D3597

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: Sergobot, kfunk, ematirov
Cc: ematirov, kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161205/99159e3f/attachment.html>