[Differential] [Requested Changes To] D3567: Fetch KConfig settings if they exist.

[kfunk (Kevin Funk)]

kfunk requested changes to this revision.
kfunk added a reviewer: kfunk.
kfunk added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> firsttimewizard.cpp:367
>  
> -    return QString();
> +    return;
>  }

Not needed

> firsttimewizard.h:67
>  
> -    QString getArduinoPath();
> -    QString getSketchbookPath();
> +    void getArduinoPath();
> +    void getSketchbookPath();

Bad function naming. `getFoo` indicates a getter.

Rather call it `fetchFoo`? Documenting the functions is even better.

REPOSITORY
  R185 KDevelop Plugin: Embedded Platforms

REVISION DETAIL
  https://phabricator.kde.org/D3567

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: obogdan, kfunk
Cc: kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161202/a38f83ed/attachment.html>