Review Request 129600: segfault when ExpressionVisitor's lastType is nullptr

[Sven Brauch]

> On Dec. 2, 2016, 8:10 a.m., Sven Brauch wrote:
> > Thanks for caring. I would prefer to change the expression visitor so it never returns a null type, i.e. initialize it to AbstractType::Ptr(new IntegralType(IntegralType::TypeMixed)) or so though.
> 
> Leslie Zhai wrote:
>     Hi Sven Brauch,
>     
>     I could *NOT* find suitable place to report kdev-ruby issues, because there is *NO* product nor component for it, then I just paste the debug info here http://kfunk.org/2016/11/30/kdevelop-seeking-maintainer-for-ruby-language-support/#comment-3030737273
>     
>     Thanks a lot!
>     
>     Regards,
>     Leslie Zhai

As Kevin said, use product kdevelop / component Language Support: Ruby.

To clarify what I meant above, go to duchain/expressionvisitor.cpp and initialize m_lastType to a mixed type instead of a null type. Then you don't have to check at every place where it's called whether the type is null or not.


- Sven


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129600/#review101208
-----------------------------------------------------------


On Dec. 2, 2016, 5:24 a.m., Leslie Zhai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129600/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2016, 5:24 a.m.)
> 
> 
> Review request for KDevelop and Kevin Funk.
> 
> 
> Repository: kdev-ruby
> 
> 
> Description
> -------
> 
> When using kdevelop import redmine (a bug tracker written in ruby http://www.redmine.org/) segfault when ExpressionVisitor's lastType is nullptr, so I simply added the check
> 
> ```
> if (ev.lastType() != nullptr)
> ```
> 
> 
> Diffs
> -----
> 
>   duchain/builders/declarationbuilder.cpp 841fc2e 
> 
> Diff: https://git.reviewboard.kde.org/r/129600/diff/
> 
> 
> Testing
> -------
> 
> import redmine
> 
> 
> Thanks,
> 
> Leslie Zhai
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161202/8fd01c8f/attachment.html>