Review Request 128797: [WIP] Session chooser dialog refactored

[Aleix Pol Gonzalez]

> On Aug. 29, 2016, 9:51 p.m., Kevin Funk wrote:
> > plugins/grepview/grepoutputmodel.cpp, line 52
> > <https://git.reviewboard.kde.org/r/128797/diff/1/?file=475613#file475613line52>
> >
> >     `setAutoTristate` is Qt 5.6 API, can't use that unconditionally.

I'd say it would be fine for 5.1. KF5 already depends on Qt 5.5 IIRC...


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128797/#review98775
-----------------------------------------------------------


On Aug. 29, 2016, 7:15 p.m., Alexander Zhigalin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128797/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2016, 7:15 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Session chooser dialog composition moved from `SessionController` to `SessionChooserDialog`
> + some litle fixes
> 
> 
> Diffs
> -----
> 
>   language/backgroundparser/backgroundparser.h 8546913 
>   language/codecompletion/codecompletionitem.h cacd3a8 
>   language/codecompletion/codecompletionmodel.cpp e89cb80 
>   language/duchain/persistentsymboltable.h 3c6cfdd 
>   language/duchain/types/integraltype.h 2de4f32 
>   plugins/grepview/grepoutputmodel.cpp ae021ee 
>   serialization/itemrepository.h a557da6 
>   shell/sessionchooserdialog.h 919829e 
>   shell/sessionchooserdialog.cpp 6078c88 
>   shell/sessioncontroller.cpp c9bf274 
> 
> Diff: https://git.reviewboard.kde.org/r/128797/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Zhigalin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160829/e08973da/attachment-0001.html>