[kdevplatform/5.0] /: find all dependencies

[Christophe Giboudeaux]

Hi,

On mardi 23 août 2016 12:18:48 CEST Harald Sitter wrote:
> Git commit b64f24d70164c65805e3fff965478a21fd74326b by Harald Sitter.
> Committed on 23/08/2016 at 12:18.
> Pushed by sitter into branch '5.0'.
> 
> find all dependencies
> 
> Summary:
> otherwise cmake falls over when it tries to create the imported targets,
> since it can't find its dependencies
> 

Only the PUBLIC link targets are needed. You added everything which is a bad 
idea. It creates needless build dependencies.

eg:

> +find_dependency(KF5Archive "@KF5_DEP_VERSION@")

private link in shell/CMakeLists.txt, language/CMakeLists.txt and used in a 
plugin that nothing can link to.

> +find_dependency(KF5GuiAddons "@KF5_DEP_VERSION@")

private link in shell/CMakeLists.txt, language/CMakeLists.txt and used in a 
plugin that nothing can link to.

and so on. Please fix this commit. Only PUBLIC targets are needed.

Christophe


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160825/d0df7126/attachment-0001.sig>