[Differential] [Request, 581 lines] D2447: Job::Parameters refactor; UI fixes; code cleanup;

[antonanikin (Anton Anikin)]

antonanikin created this revision.
antonanikin added a reviewer: kfunk.
antonanikin set the repository for this revision to rKDEVCPPCHECK KDevelop CppCheck.
Restricted Application added a subscriber: kdevelop-devel.

REVISION SUMMARY
  This patch fixes:
  
  1. code cleanup for some classes, fix coding style, remove unused includes, etc.
  
  3. '%p' placeholder for cppcheck's parameters. This allows to pass correct path for include dirs or ignored directories, for example:
  
    -I %p/include -i %p/build
  
  
  
  2. UI improvements for per-project cppcheck settings:
    - new checkboxes for '--inconclusive' and '--check-config' parameters. 'Check config' parameter is very useful for correctness setup of cppcheck.
    - new (readonly) textedit, which displays resulting cppcheck's command line. It's automatically updates when user change settings
  
  3. cppcheck::Job::Parameters class moved to separately class cppcheck::Parameters. Now it contains code for save/load it's values from system/project configs, this allows to avoid code duplication.

REPOSITORY
  rKDEVCPPCHECK KDevelop CppCheck

REVISION DETAIL
  https://phabricator.kde.org/D2447

AFFECTED FILES
  CMakeLists.txt
  config/genericconfigpage.cpp
  config/genericconfigpage.h
  config/ui/genericconfig.ui
  job.cpp
  job.h
  parameters.cpp
  parameters.h
  plugin.cpp
  plugin.h
  tests/CMakeLists.txt
  tests/test_cppcheckjob.cpp
  tests/test_cppcheckparser.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: antonanikin, kfunk
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160815/502bff03/attachment.html>