Review Request 128601: Fail early, fail verbosely

[Aleix Pol]

Done.

Cheers!
Aleix

On Sat, Aug 6, 2016 at 12:56 PM, David Nolden <
david.nolden.kdevelop at art-master.de> wrote:

> I think the check should only be enabled in debug mode, because it can
> impose efficiency problems, depending on the amount of QUrls that's being
> processed.
>
> Greetings, David
>
> 2016-08-04 19:41 GMT+02:00 Aleix Pol Gonzalez <aleixpol at kde.org>:
>
>> This is an automatically generated e-mail. To reply, visit:
>> https://git.reviewboard.kde.org/r/128601/
>> This change has been marked as submitted.
>> Review request for KDevelop.
>> By Aleix Pol Gonzalez.
>>
>> *Updated Aug. 4, 2016, 1:41 p.m.*
>> Changes
>>
>> Submitted with commit f1f053547acc0fc95114014c4d83b30c3ce4a8cf by Aleix Pol to branch 5.0.
>>
>> *Repository: * kdevplatform
>> Description
>>
>> Now we require IndexedStrings to be normalized. This makes my kdevelop crash every now and then.
>> This helped me debug the issue.
>>
>> Testing
>>
>> After this, I could easily fix a crash.
>>
>> Diffs
>>
>>    - language/editor/documentrange.h (2040456)
>>    - serialization/indexedstring.cpp (d4673a8)
>>
>> View Diff <https://git.reviewboard.kde.org/r/128601/diff/>
>>
>> _______________________________________________
>> KDevelop-devel mailing list
>> KDevelop-devel at kde.org
>> https://mail.kde.org/mailman/listinfo/kdevelop-devel
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160809/2743c7f3/attachment.html>