Review Request 128591: error location fix

[Kevin Funk]

> On Aug. 4, 2016, 7:19 a.m., Kevin Funk wrote:
> > Pushed that for you. Thanks a lot for your contribution!
> 
> Anton Anikin wrote:
>     Thanks. I have a few ideas about this plugin - should I continue to choose you as reviewer?

Sure, do that. Thanks!


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128591/#review98082
-----------------------------------------------------------


On Aug. 4, 2016, 7:18 a.m., Anton Anikin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128591/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2016, 7:18 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-cppcheck
> 
> 
> Description
> -------
> 
> Let some test.cpp file contain such code:
> 
> int x = 0; // line 100
> 
> .... // lines, which don't use the value of 'x' variable
> 
> x = 10; // line 120
> 
> Then cppcheck will produce such XML output:
> 
> <error id="redundantAssignment" ... >
>     <location file="test.cpp" line="120"/>
>     <location file="test.cpp" line="100"/>
> </error>
> 
> Old code set error location to line 100 of test.cpp (last <location> element), but it's wrong behaviour - error position must be at line 120. Current (new) version uses only first <location> element of the <error> item for getting information about error position.
> 
> 
> Diffs
> -----
> 
>   parsers/cppcheckparser.cpp aad0dca 
>   tests/test_cppcheckparser.cpp ff017e6 
> 
> Diff: https://git.reviewboard.kde.org/r/128591/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anton Anikin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160804/a16f85a8/attachment.html>