Review Request 127749: First review of embedded plugin, development of embedded systems for KDevelop.

Thu Apr 28 15:50:35 UTC 2016

> On Abril 27, 2016, 4:35 p.m., Sven Brauch wrote:
> > File Attachment: CMakeLists.txt - CMakeLists.txt
> > <https://git.reviewboard.kde.org/r/127749/#fcomment581>
> >
> >     It makes sense to define those here. But then you should use configure_file to write them out, and also use that to check the version in the code
> 
> patrick pereira wrote:
>     The version is checked by:
>     Toolkit::toolkitVersion(const QString &path)
>     
>     The ARDUINO_SDK_VERSION_NAME is used only to reference the last version supported by the plugin
> 
> Sven Brauch wrote:
>     Ok -- I still think it's a good idea to define the min and max supported version in CMakeLists.txt, then write it out and use that from C++, what do you think?
> 
> patrick pereira wrote:
>     In the actual version, the definition of min and max versions are inside the CMakeLists.txt, inside the C++ we get the version of the Arduino toolkit and check if is inside the range of min and max supported versions.
>     The next step is to use ***configure_file***  inside the CMakeLists.txt to create a more configurable plugin.  Is that what are you saying @brauch ?
> 
> Kevin Funk wrote:
>     I guess there's some misunderstanding what configure_file is about:
>     
>     @Patrick, please check the examples here: http://stackoverflow.com/questions/8887117/can-cmake-generate-configure-file
>     
>     They key point is: It's way more convenient to use variables from a generated header instead of getting them via compiler defines (the former is way more explicit).

Yes @kfunk, It's exactly what I will do. Some of kdevplatform plugins have this implementation.

- patrick

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127749/#review94910
-----------------------------------------------------------

On Abril 26, 2016, 3:05 a.m., patrick pereira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127749/
> -----------------------------------------------------------
> 
> (Updated Abril 26, 2016, 3:05 a.m.)
> 
> 
> Review request for KDevelop, Sven Brauch, Kevin Funk, and Tomaz  Canabrava.
> 
> 
> Description
> -------
> 
> Embedded plugin for KDevelop
> 
> 
> Diffs
> -----
> 
> 
> Diff: https://git.reviewboard.kde.org/r/127749/diff/
> 
> 
> Testing
> -------
> 
> Review of embedded plugin for KDevelop
> Plugin created to help the development of embedded systems.
> 
> .
> |-- CMakeLists.txt
> |-- README.md
> |-- arduinowindow.cpp
> |-- arduinowindow.h
> |-- arduinowindow.ui
> |-- boardsimg
> |   |-- ATmega644c3.svg
> |   |-- ATtiny85_breadboard.svg
> |   |-- Adafruit_Atmega32u4_Breakout.svg
> |   |-- ArduPilotMega_v15_breadboard.svg
> |   |-- Arduino\ Nano3_breadboard.svg
> |   |-- Arduino\ Voice\ Shield-v16_breadboard.svg
> |   |-- Arduino-BLE-LowPower-RevB-final_5_breadboard.svg
> |   |-- Arduino-Ethernet-v11_breadboard.svg
> |   |-- Arduino-Fio-v22_breadboard.svg
> |   |-- Arduino-Mini-v5_breadboard.svg
> |   |-- Arduino-Pro-Mini-v13_breadboard.svg
> |   |-- ArduinoBluetoothMatev13_breadboard.svg
> |   |-- Arduino_ADK_MEGA_2560-Rev3_breadboard.svg
> |   |-- Arduino_DUE_V02b_breadboard.svg
> |   |-- Arduino_Esplora_breadboard.svg
> |   |-- Arduino_Ethernet_breadboard.svg
> |   |-- Arduino_Leonardo_Rev3_breadboard.svg
> |   |-- Arduino_MEGA_2560-Rev3_breadboard.svg
> |   |-- Arduino_Micro_Rev03_breadboard.svg
> |   |-- Arduino_Pro_breadboard.svg
> |   |-- Arduino_bt07_breadboard.svg
> |   |-- Ardumoto\ v13_breadboard.svg
> |   |-- LICENSE.CC-BY-SA
> |   |-- NetduinoPlus2.svg
> |   |-- README.md
> |   |-- TI_Launchpad_MSP430G2.1_breadboard.svg
> |   |-- TI_Launchpad_MSP430G2_breadboard.svg
> |   |-- Teensy_2.0_++_breadboard.svg
> |   |-- Teensy_2.0_breadboard.svg
> |   |-- Teensy_3.0+pads_breadboard.svg
> |   |-- Teensy_3.0_breadboard.svg
> |   |-- Udoo_dual_breadboard.svg
> |   |-- Wiring_Sa99.svg
> |   |-- arduino_Uno_Rev3_breadboard-old.svg
> |   |-- arduino_Uno_Rev3_breadboard.svg
> |   |-- arduino_Yun(rev1)_breadboard.svg
> |   |-- arduino_mini_usb_adapter.svg
> |   |-- arduino_uno(rev3)-icsp_breadboard.svg
> |   |-- atlas-sientific_Conductivity\ Circuit_breadboard.svg
> |   |-- atlas-sientific_D.O.\ Circuit_breadboard.svg
> |   |-- intel-arduino-galileo_breadboard.svg
> |   |-- intel-arduino-galileo_gen2_breadboard.svg
> |   `-- intel_edison-hirosedf40_breadboard.svg
> |-- doc_templates
> |   |-- CMakeLists.txt
> |   |-- doxygen_cpp.txt
> |   |-- phpdoc_php.txt
> |   `-- rest_python.txt
> |-- embedded.cpp
> |-- embedded.h
> |-- embeddedproject
> |   |-- %{APPNAMELC}.cpp
> |   |-- %{APPNAMELC}.h
> |   |-- %{PROJECTDIRNAME}.kdev4
> |   |-- Makefile
> |   |-- embeddedproject.kdevtemplate
> |   |-- main.cpp
> |   `-- options.kcfg
> |-- firsttimewizard.cpp
> |-- firsttimewizard.h
> |-- firsttimewizard.ui
> |-- kdevembedded.json
> |-- kdevembedded.qrc
> |-- kdevembedded.rc
> |-- patrick.kdev4
> |-- toolkit.cpp
> `-- toolkit.h
> 
> 
> File Attachments
> ----------------
> 
> CMakeLists.txt
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/04/26/a8f69b53-9658-4552-8345-16a2f236fed8__CMakeLists.txt
> README.md
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/04/26/9d614ff1-c625-40b1-8a26-3ca3c6396a6f__README.md
> arduinowindow.cpp
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/04/26/6e95cc7f-a880-471f-8300-67c7584ef6fa__arduinowindow.cpp
> arduinowindow.h
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/04/26/29f98560-4081-4820-bc4b-cf0acba65f55__arduinowindow.h
> embedded.cpp
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/04/26/14591880-85df-45f7-b192-9059ef1a5a90__embedded.cpp
> embedded.h
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/04/26/3720a34d-40ff-45ad-853c-eb5955bc4287__embedded.h
> firsttimewizard.cpp
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/04/26/51f2f2ed-605c-49b1-87b7-85f6447c8274__firsttimewizard.cpp
> firsttimewizard.h
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/04/26/6171895d-b2ed-4f7d-85e8-c01dd511b17e__firsttimewizard.h
> kdevembedded.json
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/04/26/df4ccf03-fce7-43f5-be0e-11e00680ea12__kdevembedded.json
> kdevembedded.qrc
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/04/26/82f7d7ad-7e02-433c-aaa5-07fea7a8f66e__kdevembedded.qrc
> kdevembedded.rc
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/04/26/8f3d5a6d-bb86-48c9-84e7-cd5affcd750b__kdevembedded.rc
> toolkit.cpp
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/04/26/eb8ac57a-2b8c-4ba1-93d5-45e6be9d56f2__toolkit.cpp
> toolkit.h
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/04/26/88fa0dc5-af42-418a-84f8-6c1d35502c68__toolkit.h
> README.md
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/04/26/8d22467a-6f78-4c38-92af-c08438c2db13__README.md
> 
> 
> Thanks,
> 
> patrick pereira
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160428/a6e8b469/attachment-0001.html>