[Differential] [Requested Changes To] D1426: Rework SessionLock logic so it would work without D-Bus.
kfunk (Kevin Funk)
noreply at phabricator.kde.org
Mon Apr 18 09:25:10 UTC 2016
kfunk requested changes to this revision.
kfunk added a reviewer: kfunk.
kfunk added a comment.
This revision now requires changes to proceed.
I'll run the unit test on Linux after you fixed above issues.
Thanks!
INLINE COMMENTS
shell/sessionlock.cpp:83 const
shell/sessionlock.cpp:84 const
shell/sessionlock.cpp:98 Simplify: `a ? b : false => a && b`
shell/sessionlock.cpp:104 `a ? b : true => !a || b`
shell/sessionlock.cpp:106 Dito, same below
REPOSITORY
rKDEVPLATFORM KDevPlatform
REVISION DETAIL
https://phabricator.kde.org/D1426
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: arrowdodger, KDevelop, kfunk
Cc: kfunk, kdevelop-devel
More information about the KDevelop-devel
mailing list