Review Request 127669: Add back Source Browse Mode as a menu action

Igor Kushnir igorkuo at gmail.com
Sun Apr 17 15:56:54 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127669/
-----------------------------------------------------------

Review request for KDevelop.


Repository: kdevplatform


Description
-------

A recent commit "Remove confusing button in contextbrowser" removed this mode.
However this mode is useful for quick navigation when reading/debugging code.
This partially reverts commit aeb3a26837fe1510bbb5f49fffaad8d560498f65.

A menu item is not nearly as distracting and confusing as a fickle tool button.
So this commit does not reintroduce BUG 358498.


Diffs
-----

  plugins/contextbrowser/browsemanager.h efe39cdf077316602a70ae4133ea3edc499dbb38 
  plugins/contextbrowser/browsemanager.cpp 0d8f6cb494c268a49ec46fd6d3ef050598d18250 
  plugins/contextbrowser/contextbrowser.cpp f8ab2aa9f46be9482475d913d506531b353822bf 
  plugins/contextbrowser/kdevcontextbrowser.rc d6ddeada755ab9f08b9948498ec727a6535af1b5 

Diff: https://git.reviewboard.kde.org/r/127669/diff/


Testing
-------

Built, installed.
Also built and installed kdevelop with changes from https://git.reviewboard.kde.org/r/127670/
Verified the presence of the action in the Navigation menu.
Verified that a shortcut can be assigned and works.
Verified that the action works as expected: enables/disables Source Browse Mode.


Thanks,

Igor Kushnir

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160417/c2d22944/attachment.html>


More information about the KDevelop-devel mailing list