[Differential] [Commented On] D1298: Use QFileDialog in the "Open Project" dialog if we are not in KDE.

[kfunk (Kevin Funk)]

kfunk added a comment.


  Still quite a few coding style issues:
  
  Note, please use:
  `if {`
  `} else {`
  etc.
  
  (reasoning: let's not waste vertical screen space)

INLINE COMMENTS
  shell/openprojectdialog.cpp:33 Nitpick: Don't indent inside namespaces. Aids readability in case of multi-page-long namespaces.
  shell/openprojectdialog.cpp:81 Just check KDE_FULL_SESSION once.
  
  E.g.:
  `const bool useNativeFileDialog = qEnvironmentVariableIsSet("KDE_FULL_SESSION");`
  shell/openprojectdialog.cpp:154 `if (nativeDialog) ...`
  shell/openprojectdialog.cpp:156 Should probably factor out this block into a separate function for increased readability.
  shell/openprojectdialog.cpp:191 `if (openPage)`
  shell/openprojectdialog.h:67 `///` -> then Clang recognizes it as apidoc
  shell/openprojectdialog.h:68 `= nullptr;`
  shell/openprojectdialog.h:75 `= nullptr;`
  shell/openprojectdialog.h:76 `= nullptr;`

REPOSITORY
  rKDEVPLATFORM KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D1298

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: arrowdodger, KDevelop
Cc: kfunk, kdevelop-devel