Review Request 125447: IVariableController: return KTE::Range of expression instead of its text.

[Aleix Pol Gonzalez]

> On Sept. 29, 2015, 2:50 p.m., Aleix Pol Gonzalez wrote:
> > I don't really see what you're fixing here, you're just delaying the text extraction, no?
> 
> Maciej Cencora wrote:
>     Yes, this patch only lays ground for the actual fix.
>     
>     Tooltip flickering fix needs the Range of the text given tooltip is to be shown for (in order not to hide tooltip when mouse is inside this area), not the text itself.
> 
> Aleix Pol Gonzalez wrote:
>     Then I'd suggest to submit the fix for review as well. This is not something we can accept just like that.
>     
>     You can commit it separately later on.
> 
> Maciej Cencora wrote:
>     I tried, but ReviewBoard bailed out with an error on 'git cat-file <revision...>  - revision does not exist' or something like that - it was trying to read the file at revision that would be created only after applying kdevplatform part of this patch.

What about `git diff origin/master`? :)


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125447/#review86105
-----------------------------------------------------------


On Sept. 29, 2015, 11:55 a.m., Maciej Cencora wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125447/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2015, 11:55 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> This is needed to fixup flickering in debug view navigation tooltips.
> 
> I'll create seperate review request for actual fix, but I cannot do it before this gets committed.
> 
> 
> Diffs
> -----
> 
>   debugger/interfaces/ivariablecontroller.h 9303af0 
>   debugger/variable/variablecollection.cpp 703f0ec 
> 
> Diff: https://git.reviewboard.kde.org/r/125447/diff/
> 
> 
> Testing
> -------
> 
> Manual
> 
> 
> Thanks,
> 
> Maciej Cencora
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150929/e02d6178/attachment.html>