Review Request 125404: Fix one more use of function return refer to temp variable
Milian Wolff
mail at milianw.de
Sun Sep 27 18:27:21 UTC 2015
> On Sept. 27, 2015, 10:37 a.m., Zhang HuiJie wrote:
> > ConvenientIterator::ref was removed in the master branch(see https://git.reviewboard.kde.org/r/124237/ and commit 2f057e2190112e5e838ad7a04eb04a6fde6f2cde) by Milian Wolff.
Yep, this patch is for the 4.7 branch where it still applies.
- Milian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125404/#review86003
-----------------------------------------------------------
On Sept. 26, 2015, 12:33 p.m., Jingqiang Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125404/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2015, 12:33 p.m.)
>
>
> Review request for KDevelop.
>
>
> Bugs: 352618
> http://bugs.kde.org/show_bug.cgi?id=352618
>
>
> Repository: kdevelop
>
>
> Description
> -------
>
> Fix-one-more-use-of-function-return-refer-to-temp
>
>
> Diffs
> -----
>
> languages/cpp/cppduchain/environmentmanager.cpp 4c46584
>
> Diff: https://git.reviewboard.kde.org/r/125404/diff/
>
>
> Testing
> -------
>
> Kdevelop 4.7.1 crash without this patch.
> I apply it and kdevelop don't crash and KDevDefinesAndIncludesManager works.
> More info:
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=797980
>
>
> Thanks,
>
> Jingqiang Zhang
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150927/e97c8fa7/attachment.html>
More information about the KDevelop-devel
mailing list