[Differential] [Request, 83 lines] D380: Correctly remove stale next bucket links when items are removed

[olivierjg (Olivier Jean de Gaalon)]

olivierjg created this revision.
olivierjg added reviewers: KDevelop, mwolff.
olivierjg added a subscriber: KDevelop.
olivierjg set the repository for this revision to rKDEVPLATFORM KDevPlatform.
olivierjg added a project: KDevelop.
Herald added a subscriber: kdevelop-devel.

REVISION SUMMARY
      This fixes an assertion that can occur in an edge case when there
      is a clashing monster bucket followed by another clashing item.
      
      This should improve index/findIndex performance as they no longer
      need to search these stale links. It's hard to predict if this
      is significant, but at least it should prevent performance
      degradation in item repositories over time.

TEST PLAN
  Extended unit test

REPOSITORY
  rKDEVPLATFORM KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D380

AFFECTED FILES
  serialization/itemrepository.h
  serialization/tests/test_itemrepository.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: olivierjg, KDevelop, mwolff
Cc: kdevelop-devel, KDevelop, arrowdodger, obogdan, kfunk