Review Request 125305: Fix '.' to '->' member access replacement

[Sergey Kalinichev]

> On Sept. 23, 2015, 11:31 p.m., Luis Felipe Dominguez Vega wrote:
> > Well i test that with the code "double a = 0." in that case kdev-clang convert the '.' into "->" and i need "make magic" to put the '.'
> 
> Aleix Pol Gonzalez wrote:
>     Hi.
>     I have the same problem. Also when there's parsing errors it does funny stuff. :/
> 
> Sergey Kalinichev wrote:
>     Should be fixed by b493cc03. Please, retest!
>     
>     Aleix, could you maybe provide a test case? I don't know what parsing error should be present to trigger that behavior...
> 
> Aleix Pol Gonzalez wrote:
>     There's many ways to get a parsing error. For example:
>     `awesome.|`
>     If awesome isn't declared, it will automatically change to an `->`.

Still can't reproduce it... Maybe it has something to do with LibClang version or parser arguments? 
I tested it with LibClang 3.5 and 3.8 (from svn) and default parser arguments.


- Sergey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125305/#review85846
-----------------------------------------------------------


On Sept. 21, 2015, 9:40 a.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125305/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2015, 9:40 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Clang doesn't provide diagnostic for it. So let't try to manually determine whether this is the case, this is not so hard after all.
>     
> This also means that now we use clang_codeCompleteAt twice, but it doesn't matter much here as the input is already invalid, hence no completion items.
> 
> 
> Diffs
> -----
> 
>   codecompletion/context.h 827e044 
>   codecompletion/context.cpp 995b4b0 
>   codecompletion/model.cpp 2442e38 
>   tests/test_codecompletion.cpp a2ed37f 
> 
> Diff: https://git.reviewboard.kde.org/r/125305/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150925/3969bcdf/attachment.html>